Fix PutIndexTemplateRequest deserialization (#765) #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix PutIndexTemplateRequest deserialization Signed-off-by: Matthew Bogner <matt@ibogner.net> * CHANGELOG.md Signed-off-by: Matthew Bogner <matt@ibogner.net> * spotless Signed-off-by: Matthew Bogner <matt@ibogner.net> --------- Signed-off-by: Matthew Bogner <matt@ibogner.net> (cherry picked from commit d4aade4)
matthewbogner
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
VachaShah
approved these changes
Dec 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in the missing deserialization steps to the PutIndexTemplateRequest _DESERIALIZER which would result in the error
Missing required property 'PutIndexTemplateRequest.name' if you tried to deserialize a request object.
Issues Resolved
Relates to issues #417, #618 and PR #723
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Matthew Bogner matt@ibogner.net
(cherry picked from commit d4aade4)
Backport of #765