Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integtest.sh in every repo. #80

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 16, 2021

Signed-off-by: dblock dblock@dblock.org

Description

A bit of meta work to make PRs in all repos that remove a file needed by opensearch-project/opensearch-build#497.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Comment on lines +91 to +96
meta exec "git rm integtest.sh"
meta exec "git add --all"
meta exec "git checkout -b remove-integtest-sh"
meta exec "git commit -s -m 'Removed integtest.sh.'"
meta exec "git push username remove-integtest-sh"
meta exec "gh pr create --title 'Removing default integtest.sh.' --body='Coming from https://github.com/opensearch-project/opensearch-build/issues/497, removing default integtest.sh.'"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Curious - If a repo doesn't have the integtest.sh file, is that gracefully handled with this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it just fails through. If there's nothing to PR, it doesn't do anything.

@dblock
Copy link
Member Author

dblock commented Sep 16, 2021

Lychee fixed in #81

Signed-off-by: dblock <dblock@dblock.org>
Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@dblock dblock merged commit 4b25805 into opensearch-project:main Sep 17, 2021
@dblock dblock deleted the remove-integtest-sh branch September 17, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants