-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote table name with backticks to escape special characters in spark.read.table() #224
Quote table name with backticks to escape special characters in spark.read.table() #224
Conversation
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check if this also needs change: https://github.com/opensearch-project/opensearch-spark/blob/main/flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSpark.scala#L375C28-L375C28
Missed that one.. added the change. |
Signed-off-by: Sean Kao <seankao@amazon.com>
No problem. Should be fine if all existing IT can pass. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.1 0.1
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.1
# Create a new branch
git switch --create backport/backport-224-to-0.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6e163e77a2d8598ad105835f3ce20677d84fea84
# Push it to GitHub
git push --set-upstream origin backport/backport-224-to-0.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.1 Then, create a pull request where the |
….read.table() (opensearch-project#224) * quote table name for special character in df read Signed-off-by: Sean Kao <seankao@amazon.com> * add UT Signed-off-by: Sean Kao <seankao@amazon.com> * update comments; scalafmtAll Signed-off-by: Sean Kao <seankao@amazon.com> * add a missed table name to quote Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit 6e163e7)
….read.table() (opensearch-project#224) * quote table name for special character in df read Signed-off-by: Sean Kao <seankao@amazon.com> * add UT Signed-off-by: Sean Kao <seankao@amazon.com> * update comments; scalafmtAll Signed-off-by: Sean Kao <seankao@amazon.com> * add a missed table name to quote Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit 6e163e7)
….read.table() (#224) (#225) * quote table name for special character in df read Signed-off-by: Sean Kao <seankao@amazon.com> * add UT Signed-off-by: Sean Kao <seankao@amazon.com> * update comments; scalafmtAll Signed-off-by: Sean Kao <seankao@amazon.com> * add a missed table name to quote Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit 6e163e7)
Description
Quote table name with backticks to escape special characters in spark.read.table()
Follow up on
which allows for creating flint index on table name with special characters, but build() on these index fails if table name not escaped by backticks (
`
)Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.