Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Improve serialization speeds (#2802) #3444

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 3, 2023

Backport #2802 to 2.x

Paras Jain and others added 2 commits September 30, 2023 11:20
Use custom serialization in security plugin.
- Resolves opensearch-project#2780

Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Co-authored-by: Paras Jain <parasjaz@amazon.com>
Co-authored-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #3444 (4aaba72) into 2.x (a2daf9f) will increase coverage by 0.45%.
Report is 14 commits behind head on 2.x.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3444      +/-   ##
============================================
+ Coverage     64.11%   64.56%   +0.45%     
- Complexity     3367     3507     +140     
============================================
  Files           256      260       +4     
  Lines         19515    19714     +199     
  Branches       3297     3306       +9     
============================================
+ Hits          12512    12729     +217     
+ Misses         5360     5353       -7     
+ Partials       1643     1632      -11     
Files Coverage Δ
.../main/java/com/amazon/dlic/auth/ldap/LdapUser.java 89.28% <100.00%> (+3.57%) ⬆️
...earch/security/auditlog/impl/AbstractAuditLog.java 76.53% <100.00%> (+0.10%) ⬆️
...ava/org/opensearch/security/auth/UserInjector.java 90.66% <100.00%> (+0.66%) ⬆️
...org/opensearch/security/filter/SecurityFilter.java 66.66% <100.00%> (+0.80%) ⬆️
...urity/ssl/transport/SecuritySSLRequestHandler.java 62.22% <100.00%> (+3.13%) ⬆️
.../org/opensearch/security/support/Base64Helper.java 90.90% <100.00%> (+23.63%) ⬆️
...g/opensearch/security/support/ConfigConstants.java 95.23% <100.00%> (+0.23%) ⬆️
.../org/opensearch/security/support/HeaderHelper.java 62.50% <100.00%> (+2.50%) ⬆️
...rch/security/transport/SecurityRequestHandler.java 55.03% <100.00%> (+0.30%) ⬆️
...c/main/java/org/opensearch/security/user/User.java 71.95% <100.00%> (+15.70%) ⬆️
... and 7 more

... and 20 files with indirect coverage changes

@DarshitChanpura DarshitChanpura added the v2.11.0 Issues targeting the 2.11 release label Oct 3, 2023
@DarshitChanpura DarshitChanpura merged commit 5195d5e into opensearch-project:2.x Oct 3, 2023
57 checks passed
@cwperks cwperks mentioned this pull request Oct 3, 2023
3 tasks
peternied added a commit that referenced this pull request Oct 4, 2023
Update custom serialization min supported version, should be 2.11.0
since the features backport [1] was merged.

- [1] #3444 

Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.11.0 Issues targeting the 2.11 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants