Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build Break] Update custom serialization min supported version #3458

Merged

Conversation

peternied
Copy link
Member

@peternied peternied commented Oct 4, 2023

Description

Update custom serialization min supported version, should be 2.11.0 since the features backport [1] was merged.

Issues Resolved

⚠️ I will be bypassing approval to merge this change to unblock the pipeline as soon as all of the backward-compatibility* tests have passed.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied marked this pull request as ready for review October 4, 2023 19:59
@peternied peternied changed the title Update custom serialization min supported version [Build Break] Update custom serialization min supported version Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #3458 (a2cdd48) into main (e4a1b77) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3458   +/-   ##
=========================================
  Coverage     64.57%   64.57%           
  Complexity     3547     3547           
=========================================
  Files           269      269           
  Lines         20365    20365           
  Branches       3377     3377           
=========================================
  Hits          13151    13151           
  Misses         5526     5526           
  Partials       1688     1688           
Files Coverage Δ
...g/opensearch/security/support/ConfigConstants.java 95.23% <100.00%> (ø)

willyborankin
willyborankin previously approved these changes Oct 4, 2023
@peternied
Copy link
Member Author

Looks like there is a test failure, I'm investigating org.opensearch.security.transport.SecuritySSLRequestHandlerTests.testUseJDKSerializationHeaderIsSetOnMessageReceived

Signed-off-by: Peter Nied <petern@amazon.com>
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but will spend some more time to understand the values being changed in this PR.

@peternied peternied merged commit 93f79f8 into opensearch-project:main Oct 4, 2023
58 checks passed
@peternied peternied deleted the min-serialization-version branch October 4, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BWC tests started to fail for all new PRs
3 participants