-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the audit config being null #4650
Handle the audit config being null #4650
Conversation
This was causing an error if the audit config was null and was posted to the event bus. Signed-off-by: Merlin <na@notaccessible.xyz>
Would a different constructor work? i.e. |
Signed-off-by: Merlin <na@notaccessible.xyz>
Trying |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4650 +/- ##
=======================================
Coverage 65.26% 65.26%
=======================================
Files 317 317
Lines 22311 22312 +1
Branches 3588 3589 +1
=======================================
+ Hits 14562 14563 +1
Misses 5954 5954
Partials 1795 1795
|
Signed-off-by: Merlin <na@notaccessible.xyz> (cherry picked from commit d76bbfb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was causing an error if the audit config was null and was posted to the event bus.
Description
Old behavior:
Lots of errors when the audit config is missing
New behavior:
Audit config is set to the default when missing
Issues Resolved
#4315
https://forum.opensearch.org/t/ava-lang-nullpointerexception-cannot-invoke-object-getclass-because-event-is-null/20821/
Is this a backport? No.
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? No.
Testing
None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.