Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Handle the audit config being null #4664

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[Backport 2.x] Handle the audit config being null #4664

merged 1 commit into from
Aug 19, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d76bbfb from #4650.

@github-actions
Handle the audit config being null (#4650)
67d8c1d 
Signed-off-by: Merlin <na@notaccessible.xyz>
(cherry picked from commit d76bbfb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (2.x@486646c). Learn more about missing BASE report.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...ch/security/securityconf/DynamicConfigFactory.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x    #4664   +/-   ##
======================================
  Coverage       ?   65.38%           
======================================
  Files          ?      316           
  Lines          ?    22143           
  Branches       ?     3579           
======================================
  Hits           ?    14479           
  Misses         ?     5870           
  Partials       ?     1794
Files Coverage Δ
...ch/security/securityconf/DynamicConfigFactory.java 54.54% <50.00%> (ø)

@cwperks cwperks merged commit 59c737a into 2.x Aug 19, 2024
91 checks passed
@cwperks cwperks deleted the backport/backport-4650-to-2.x branch August 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwperks cwperks cwperks approved these changes

@shikharj05 shikharj05 shikharj05 approved these changes

@cliu123 cliu123 Awaiting requested review from cliu123

@DarshitChanpura DarshitChanpura Awaiting requested review from DarshitChanpura DarshitChanpura is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@willyborankin willyborankin Awaiting requested review from willyborankin willyborankin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikharj05 @cwperks