Update TIMESTAMP function implementation and signatures.
#1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1254 +/- ##
============================================
- Coverage 98.35% 98.35% -0.01%
- Complexity 3617 3618 +1
============================================
Files 343 343
Lines 8927 8923 -4
Branches 569 569
============================================
- Hits 8780 8776 -4
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
YANG-DB
previously approved these changes
Jan 9, 2023
dai-chen
reviewed
Jan 17, 2023
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Outdated
Show resolved
Hide resolved
87 tasks
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ime types cast (PR opensearch-project#1196). Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
dai-chen
previously approved these changes
Jan 26, 2023
acarbonetto
previously approved these changes
Jan 27, 2023
| @@ -419,7 +419,12 @@ public static FunctionExpression time_to_sec(Expression... expressions) { | |||
| } | |||
|
|
|||
| public static FunctionExpression timestamp(Expression... expressions) { | |||
There was a problem hiding this comment.
Why leave this function signature? There are only about 10 tests to update to remove this.
There was a problem hiding this comment.
All functions from this file are used in tests only.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
dismissed stale reviews from acarbonetto and dai-chen
via
2e04408
acarbonetto
approved these changes
Feb 10, 2023
dai-chen
approved these changes
Feb 10, 2023
MaxKsyunz
approved these changes
Feb 14, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Update `TIMESTAMP` function implementation and signatures. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Simplify `TIMESTAMP` function implementation by using automatic datetime types cast (PR #1196). Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Checkstyle fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit ecb9dec)
dai-chen
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1340) * Update `TIMESTAMP` function implementation and signatures. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Simplify `TIMESTAMP` function implementation by using automatic datetime types cast (PR #1196). Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Checkstyle fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit ecb9dec) Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand yury.fridlyand@improving.com
Description
I referred to MySQL docs and tried to reproduce MySQL v.8.0.30 behavior as a reference.
See team review and discussion in Bit-Quill#139
Updated function:
TIMESTAMPSignatures
Notes:
Unlike MySQL,
TIMESTAMPfunction returns aTIMESTAMPobject (Instant), not aDATETIME.Test queries:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.