Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in development filesystem support #1284

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Jan 17, 2023

Signed-off-by: Peng Huo penghuo@gmail.com

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #1284 (2607711) into main (9d4a841) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1284      +/-   ##
============================================
- Coverage     98.35%   98.34%   -0.01%     
+ Complexity     3609     3600       -9     
============================================
  Files           344      343       -1     
  Lines          8946     8908      -38     
  Branches        569      567       -2     
============================================
- Hits           8799     8761      -38     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo marked this pull request as ready for review January 18, 2023 00:23
@penghuo penghuo requested a review from a team as a code owner January 18, 2023 00:23
@penghuo penghuo self-assigned this Jan 18, 2023
@penghuo penghuo merged commit 6a90fe6 into opensearch-project:main Jan 18, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1284-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a90fe63699723c406cbca9e3d34eddcf92bcc67
# Push it to GitHub
git push --set-upstream origin backport/backport-1284-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1284-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-1284-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a90fe63699723c406cbca9e3d34eddcf92bcc67
# Push it to GitHub
git push --set-upstream origin backport/backport-1284-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-1284-to-2.5.

penghuo added a commit to penghuo/os-sql that referenced this pull request Jan 19, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 6a90fe6)
penghuo added a commit to penghuo/os-sql that referenced this pull request Jan 19, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 6a90fe6)
penghuo added a commit to penghuo/os-sql that referenced this pull request Jan 19, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 6a90fe6)
Signed-off-by: Peng Huo <penghuo@gmail.com>
penghuo added a commit to penghuo/os-sql that referenced this pull request Jan 19, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 6a90fe6)
Signed-off-by: Peng Huo <penghuo@gmail.com>
YANG-DB pushed a commit that referenced this pull request Jan 19, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 6a90fe6)
Signed-off-by: Peng Huo <penghuo@gmail.com>

Signed-off-by: Peng Huo <penghuo@gmail.com>
YANG-DB pushed a commit that referenced this pull request Jan 19, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 6a90fe6)
Signed-off-by: Peng Huo <penghuo@gmail.com>

Signed-off-by: Peng Huo <penghuo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants