Resolve table function based on StorageEngine provided function resolver #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <penghuo@gmail.com>
penghuo
commented
Feb 16, 2023
| @@ -8,5 +8,5 @@ | |||
| public enum DataSourceType { | |||
| PROMETHEUS, | |||
| OPENSEARCH, | |||
| FILESYSTEM | |||
| JDBC | |||
There was a problem hiding this comment.
FILESYSTEM supported has been removed in #1284.
penghuo
commented
Feb 16, 2023
| @@ -62,7 +62,7 @@ dependencies { | |||
| test { | |||
| useJUnitPlatform() | |||
| testLogging { | |||
| events "passed", "skipped", "failed" | |||
| events "skipped", "failed" | |||
There was a problem hiding this comment.
Ignore log PASSED test cases.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1354 +/- ##
============================================
- Coverage 98.38% 98.38% -0.01%
+ Complexity 3698 3695 -3
============================================
Files 343 343
Lines 9121 9113 -8
Branches 586 582 -4
============================================
- Hits 8974 8966 -8
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
anirudha
previously approved these changes
Mar 6, 2023
|
To reviewer: Ignore failed bwc test. |
YANG-DB
previously approved these changes
Mar 6, 2023
dai-chen
previously approved these changes
Mar 6, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
YANG-DB
approved these changes
Mar 10, 2023
ps48
approved these changes
Mar 10, 2023
penghuo
added a commit
that referenced
this pull request
Mar 14, 2023
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#1331
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.