Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support More Formats For GET_FORMAT Function #1343

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Support More Formats For GET_FORMAT Function #1343

merged 1 commit into from
Feb 16, 2023

Conversation

GabeFernandez310
Copy link
Contributor

Description

Adds the support to the get_format function to the OpenSearch SQL Plugin for JIS, ISO, EUR, and INTERNAL formats for DATE, TIME, TIMESTAMP and DATETIME. It's implementation is aligned with the MySQL Documentation.

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner February 15, 2023 16:14
@GabeFernandez310 GabeFernandez310 marked this pull request as draft February 15, 2023 16:15
@GabeFernandez310
Added Support For More Formats For Get_Format
f068442 
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
@GabeFernandez310 GabeFernandez310 force-pushed the integ-add-get_format-function-formats branch from 7f611e9 to f068442 Compare February 15, 2023 16:24
@GabeFernandez310 GabeFernandez310 marked this pull request as ready for review February 15, 2023 16:25
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Feb 15, 2023
Closed
87 tasks
@dai-chen dai-chen added the enhancement New feature or request label Feb 16, 2023
@dai-chen dai-chen merged commit 672c72f into opensearch-project:main Feb 16, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2023
@GabeFernandez310 @github-actions
Added Support For More Formats For Get_Format (#1343)
aa42ce0 
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 672c72f)
penghuo pushed a commit that referenced this pull request Feb 16, 2023
@opensearch-trigger-bot @GabeFernandez310
Added Support For More Formats For Get_Format (#1343) (#1349)
4afe013 
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 672c72f)

Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@dai-chen dai-chen dai-chen approved these changes

Assignees
No one assigned
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GabeFernandez310 @dai-chen @Yury-Fridlyand @MaxKsyunz