-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TIMESTAMPADD
Function To OpenSearch SQL Plugin
#1451
Add TIMESTAMPADD
Function To OpenSearch SQL Plugin
#1451
Conversation
Added Testing And Implementation for TIMESTAMPADD Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1451 +/- ##
============================================
+ Coverage 98.43% 98.44% +0.01%
- Complexity 3775 3806 +31
============================================
Files 343 343
Lines 9364 9449 +85
Branches 599 601 +2
============================================
+ Hits 9217 9302 +85
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Add `TIMESTAMPADD` Function To OpenSearch SQL Plugin Added Testing And Implementation for TIMESTAMPADD Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Formatting Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> --------- Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit 7b83e50)
* Add `TIMESTAMPADD` Function To OpenSearch SQL Plugin Added Testing And Implementation for TIMESTAMPADD Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Formatting Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> --------- Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit 7b83e50) Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Description
Adds the
timestampadd()
function to the OpenSearch SQL Plugin. Based off of the MySQL Implementation, but some changes were made due to the limitations of the plugin. Specifically, the return of this function is always aDATETIME
. If an argument of typeTIME
is provided for the third argument, theDATE
portion of the returnedDATETIME
will be filled in with values using the current date.Examples:
Issues Resolved
#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.