Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Support to V2 Engine (#217) #1464

Closed

Commits on Mar 23, 2023

  1. Add JSON Support to V2 Engine (#217)

    * Implement json support for V2 engine
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Reverted some changes
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Removed some fields
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * minor fix
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Added a unit test, cleaned up
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Returning raw OpenSearch response when type is json
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Add an integration test, fix checkstyle errors
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Added constructor for empty rawResponse
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added constant for supported formats
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added unit test
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Addressed PR comments
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Addressed PR comments:
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Fixed issue
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added getter for rawResponse in PhysicalPlan
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Legacy fall back with JSON format (#237)
    
    * Implement json support for V2 engine
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Reverted some changes
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Removed some fields
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * minor fix
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Added a unit test, cleaned up
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Returning raw OpenSearch response when type is json
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Add an integration test, fix checkstyle errors
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    
    * Made new engine fallback to legacy for in memory operations for json format
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Address build failures
    
    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    
    * Added legacy fall back
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Refactored fall back logic to use visitor design pattern
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added unit tests
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Removed unnecessary IT
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Addressed PR feedback
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Removed unnecessary context
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added fall back for Filter functions
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Made new engine fallback to legacy for in memory operations for json format
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Address build failures
    
    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    
    * Added legacy fall back
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Refactored fall back logic to use visitor design pattern
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added unit tests
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Removed unnecessary IT
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Addressed PR feedback
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Removed unnecessary context
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added fall back for Filter functions
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    
    ---------
    
    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    
    * Fixed checkstyle errors
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Addressed PR comments and fixed the visitor
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added comment to visitor class
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Addressed PR comments to improve visitor class
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added unit tests for JsonSupportVisitor
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added helper function for SQLServiceTest
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added expected failures
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Reworked the visitor class to have type Void instead of Boolean
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Fixed typo
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added github link for tracking issue
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    ---------
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    Co-authored-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
    
    * Reverted OpenSearchIndexScan changes as it broke IT
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Added unit test
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Removed unused Mock variable
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    ---------
    
    Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
    Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
    3 people authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    707d88e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Changed visitor type to Boolean and added LIMIT to fall back to legacy (

    #255)
    
    * Changed visitor type to Boolean and added LIMIT to fall back to legacy
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    * Addressed PR comment
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    
    ---------
    
    Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
    GumpacG authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    4e692fe View commit details
    Browse the repository at this point in the history