Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flint describe index SQL support #1785

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Jun 26, 2023

Description

Add DESCRIBE/DESC SKIPPING INDEX statement. The skip type name below may be changed in #1800

Example: (Later will add to doctest)

$ spark-sql --hiveconf hive.cli.print.header=true

spark-sql> desc skipping index on http_logs;
indexed_col_name	data_type	skip_type
year	int	Partition
month	int	Partition
day	int	Partition
status	int	ValuesSet

Issues Resolved

opensearch-project/opensearch-spark#2

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added enhancement New feature or request Flint labels Jun 26, 2023
@dai-chen dai-chen self-assigned this Jun 26, 2023
@dai-chen dai-chen changed the title Add SQL support for describe skipping index statement Add Flint describe index SQL support Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1785 (807a1be) into feature/flint (ae3389d) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             feature/flint    opensearch-project/sql#1785   +/-   ##
================================================
  Coverage            97.19%   97.19%           
  Complexity            4107     4107           
================================================
  Files                  371      371           
  Lines                10464    10464           
  Branches               706      706           
================================================
  Hits                 10170    10170           
  Misses                 287      287           
  Partials                 7        7           
Flag Coverage Δ
sql-engine 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

dai-chen added 2 commits June 27, 2023 14:28
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review June 30, 2023 21:31
@dai-chen dai-chen merged commit 91b2a06 into opensearch-project:feature/flint Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Flint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants