Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flint create and refresh index SQL support #1800

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Jun 28, 2023

Description

  1. Add SQL support for create and refresh skipping index statement. Please find SQL syntax and example in https://github.com/dai-chen/sql-1/blob/add-create-skipping-index-sql-statement/flint/docs/index.md#sql
  2. Rename skipping kind to match its name in SQL grammar
  3. Add check for manual refresh on incremental refreshing index

Issues Resolved

opensearch-project/opensearch-spark#2

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added enhancement New feature or request Flint labels Jun 28, 2023
@dai-chen dai-chen self-assigned this Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1800 (ba56339) into feature/flint (91b2a06) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             feature/flint    #1800   +/-   ##
================================================
  Coverage            97.19%   97.19%           
  Complexity            4107     4107           
================================================
  Files                  371      371           
  Lines                10464    10464           
  Branches               706      706           
================================================
  Hits                 10170    10170           
  Misses                 287      287           
  Partials                 7        7           
Flag Coverage Δ
sql-engine 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen force-pushed the add-create-skipping-index-sql-statement branch from 0069384 to bc8630d Compare July 5, 2023 16:31
dai-chen added 4 commits July 5, 2023 10:23
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review July 5, 2023 22:02
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen merged commit 22b9c0a into opensearch-project:feature/flint Jul 12, 2023
@dai-chen dai-chen deleted the add-create-skipping-index-sql-statement branch July 12, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Flint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants