-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL pagination should work with the pretty
parameter
#2759
SQL pagination should work with the pretty
parameter
#2759
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
pretty
parameter
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
=========================================
Coverage 92.14% 92.14%
Complexity 4960 4960
=========================================
Files 496 496
Lines 14341 14345 +4
Branches 942 945 +3
=========================================
+ Hits 13214 13218 +4
Misses 1091 1091
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
boolean hasQuery = query != null; | ||
boolean hasContent = jsonContent != null && !jsonContent.isEmpty(); | ||
|
||
Predicate<String> supportedParams = List.of(QUERY_PARAMS_FORMAT, QUERY_PARAMS_PRETTY)::contains; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NIT]won't Set.of would be more appropriate here?
Any ITs with pretty parameter? Is pretty parameter working? |
Currently we don't have a dedicated IT for testing pretty parameter. But we added some tests in |
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Hi @vamsi-amazon @penghuo @dai-chen, could you review and approve this PR again since I addressed comments. |
Signed-off-by: Lantao Jin <ltjin@amazon.com>
None of build issues are related to this code changes. But anyone knows why our CI has lots of failures in recent one or two weeks? |
Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 0c2e1da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#2759) Signed-off-by: Lantao Jin <ltjin@amazon.com>
…oject#2759) Signed-off-by: Lantao Jin <ltjin@amazon.com>
…oject#2759) Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 0c2e1da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
isSupported()
improves readability by clearly defining each condition and simplifying the overall logic.PRETTY
(plusFORMAT
) parameters should be treated as supported in validatingCursor
request.Issues Resolved
resolves #2460
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.