Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] SQL pagination should work with the pretty parameter #2828

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0c2e1da from #2759.

Signed-off-by: Lantao Jin <ltjin@amazon.com>
(cherry picked from commit 0c2e1da)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (f7c1f09) to head (882c836).
Report is 60 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #2828   +/-   ##
=========================================
  Coverage     94.66%   94.66%           
  Complexity     5180     5180           
=========================================
  Files           511      511           
  Lines         14639    14643    +4     
  Branches        944      947    +3     
=========================================
+ Hits          13858    13862    +4     
  Misses          740      740           
  Partials         41       41           
Flag Coverage Δ
sql-engine 94.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LantaoJin
Copy link
Member

LantaoJin commented Jul 16, 2024

The build failure is caused by missing a prerequisite backport PR #2829.

@LantaoJin
Copy link
Member

Ping @penghuo @dai-chen

@Swiddis Swiddis added the v2.18.0 Issues targeting release v2.18.0 label Oct 23, 2024
@Swiddis Swiddis merged commit 2d3d3d8 into 2.x Oct 23, 2024
48 of 50 checks passed
@Swiddis Swiddis deleted the backport/backport-2759-to-2.x branch October 23, 2024 18:42
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
…#2828)

(cherry picked from commit 0c2e1da)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
(cherry picked from commit 2d3d3d8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18 v2.18.0 Issues targeting release v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants