add groupId to pluginzip publication #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <penghuo@gmail.com>
peterzhuamazon
approved these changes
Oct 12, 2022
joshuali925
approved these changes
Oct 12, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #906 +/- ##
============================================
- Coverage 97.90% 95.10% -2.81%
Complexity 3072 3072
============================================
Files 293 303 +10
Lines 7588 8246 +658
Branches 490 609 +119
============================================
+ Hits 7429 7842 +413
- Misses 158 350 +192
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-906-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a8553f7765de1f34158c887cc805728b09c9d154
# Push it to GitHub
git push --set-upstream origin backport/backport-906-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
Hey @penghuo it should be actually |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com> (cherry picked from commit a8553f7)
GabeFernandez310
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peng Huo penghuo@gmail.com
Description
Added groupId as org.opensearch.plugin in pluginZip publication
Issues Resolved
opensearch-project/opensearch-build#2521
#790
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.