Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update group to groupId #908

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 12, 2022

Signed-off-by: Peng Huo penghuo@gmail.com

Description

Change group to groupId

Issues Resolved

#906

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner October 12, 2022 20:57
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you restore the PNG deleted (if you are on mac #865 would delete lowercase png (unused one), running git checkout sql-jdbc/docs/img/tableau_graph.PNG can restore the uppercase PNG (correct one). i explained here #865 (comment))

Signed-off-by: Peng Huo <penghuo@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #908 (14e814a) into 2.x (a8553f7) will decrease coverage by 2.80%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #908      +/-   ##
============================================
- Coverage     97.90%   95.10%   -2.81%     
  Complexity     3072     3072              
============================================
  Files           293      303      +10     
  Lines          7588     8246     +658     
  Branches        490      609     +119     
============================================
+ Hits           7429     7842     +413     
- Misses          158      350     +192     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@prudhvigodithi
Copy link
Member

Hey @penghuo looks good, please make sure this change is part of main as well https://github.com/opensearch-project/sql/blob/main/plugin/build.gradle.
Thank you

@penghuo penghuo merged commit b30d156 into opensearch-project:2.x Oct 12, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-908-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b30d1567367f0de1c7f17f6930513b91050623a0
# Push it to GitHub
git push --set-upstream origin backport/backport-908-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-908-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-908-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b30d1567367f0de1c7f17f6930513b91050623a0
# Push it to GitHub
git push --set-upstream origin backport/backport-908-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-908-to-main.

joshuali925 pushed a commit that referenced this pull request Oct 12, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
@joshuali925
Copy link
Member

backport main: #909

vmmusings pushed a commit to vmmusings/sql that referenced this pull request Oct 18, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vmmusings pushed a commit to vmmusings/sql that referenced this pull request Oct 18, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vmmusings pushed a commit to vmmusings/sql that referenced this pull request Oct 18, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vmmusings pushed a commit to vmmusings/sql that referenced this pull request Oct 18, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
GabeFernandez310 pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 19, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants