-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update group to groupId #908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you restore the PNG deleted (if you are on mac #865 would delete lowercase png (unused one), running git checkout sql-jdbc/docs/img/tableau_graph.PNG
can restore the uppercase PNG (correct one). i explained here #865 (comment))
Signed-off-by: Peng Huo <penghuo@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #908 +/- ##
============================================
- Coverage 97.90% 95.10% -2.81%
Complexity 3072 3072
============================================
Files 293 303 +10
Lines 7588 8246 +658
Branches 490 609 +119
============================================
+ Hits 7429 7842 +413
- Misses 158 350 +192
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hey @penghuo looks good, please make sure this change is part of |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-908-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b30d1567367f0de1c7f17f6930513b91050623a0
# Push it to GitHub
git push --set-upstream origin backport/backport-908-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-908-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b30d1567367f0de1c7f17f6930513b91050623a0
# Push it to GitHub
git push --set-upstream origin backport/backport-908-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
Signed-off-by: Peng Huo <penghuo@gmail.com>
backport main: #909 |
Signed-off-by: Peng Huo <penghuo@gmail.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: Peng Huo <penghuo@gmail.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: Peng Huo <penghuo@gmail.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: Peng Huo <penghuo@gmail.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo penghuo@gmail.com
Description
Change group to groupId
Issues Resolved
#906
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.