Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[konflux] allow field to override konflux template url #4313

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[konflux] allow field to override konflux template url #4313

merged 1 commit into from
Dec 13, 2024

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Dec 12, 2024 •
edited
Loading

@ashwindasr ashwindasr mentioned this pull request Dec 12, 2024
Merged
@ashwindasr
Copy link
Contributor Author

/hold

until openshift-eng/art-tools#1213 is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d0819dd link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vfreex
vfreex reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@vfreex vfreex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@ashwindasr ashwindasr removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 294affa into openshift-eng:master Dec 13, 2024
1 of 2 checks passed
@ashwindasr ashwindasr deleted the konflux-plr-template-option branch December 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfreex vfreex vfreex left review comments

Assignees

@vfreex vfreex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwindasr @vfreex