Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[konflux] allow field to override konflux template url #1213

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Dec 12, 2024

Since we are now dynamically pulling the PipelineRun template from https://github.com/openshift-priv/art-konflux-template/blob/main/.tekton/art-konflux-template-push.yaml, in case if there is an issue with one of the newer task builds, having this option will allow us to use a temporary roll back if necessary, instead of merging a revert PR, thereby offering us more flexibility.

Alongside openshift-eng/aos-cd-jobs#4313

@ashwindasr ashwindasr force-pushed the konflux-override-template-plr branch from cc467e7 to 20ffa6a Compare December 12, 2024 18:53
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 20ffa6a link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vfreex
Copy link
Contributor

vfreex commented Dec 13, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9bbed81 into openshift-eng:main Dec 13, 2024
2 of 3 checks passed
@ashwindasr ashwindasr deleted the konflux-override-template-plr branch December 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants