operator/ingress: make .spec.endpointPublishingStrategy.type required #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Miciah
reviewed
Sep 25, 2019
| @@ -244,6 +244,7 @@ type EndpointPublishingStrategy struct { | |||
| // networking, and is not explicitly published. The user must manually publish | |||
| // the ingress controller. | |||
| // +unionDiscriminator | |||
| // +kubebuilder:validation:Required | |||
There was a problem hiding this comment.
Elsewhere I see +kubebuilder:validation:Required paired with +required (I would guess for consistency across various tools), so we should probably use both markers here.
There was a problem hiding this comment.
Yeah, +required is for backwards compatibility/consistency. Both are supported
|
Followup to #440 |
The `.spec.endpointPublishingStrategy.type` is intended to be required (and that's how the field is persisted in 4.1). In the operator.openshift.io group, fields are optional by default[1]. Use an explicit marker to maintain compatibility. [1] https://github.com/openshift/api/blob/master/operator/v1/doc.go
ironcladlou
force-pushed
the
ingress-required-fix
branch
from
3ea080e
to
ac32a08
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.spec.endpointPublishingStrategy.typeis intended to be required (andthat's how the field is persisted in 4.1). In the operator.openshift.io group,
fields are optional by default[1]. Use an explicit marker to maintain
compatibility.
[1] https://github.com/openshift/api/blob/master/operator/v1/doc.go