Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-61: Rebase cert-manager v1.11 #113

Merged
merged 7 commits into from
Apr 21, 2023
Merged

CM-61: Rebase cert-manager v1.11 #113

merged 7 commits into from
Apr 21, 2023

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Apr 6, 2023 •
edited
Loading

[v1.11.0] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.0
go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go get sigs.k8s.io/controller-tools@v0.11.3 # latest
go get sigs.k8s.io/controller-runtime@v0.14.6 # latest
go get cloud.google.com/go/compute/metadata@latest # 0.2.3, added due to a conflict

go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

v1.11.0

v1.11.0 includes a drastic reduction in cert-manager's runtime memory usage, a slew of improvements to AKS integrations and various other tweaks, fixes and improvements, all towards cert-manager's goal of being the best way to handle certificates in modern Cloud Native applications.

Feature: cert-manager/cert-manager#5554, cert-manager/cert-manager#5638, cert-manager/cert-manager#5644, cert-manager/cert-manager#5646, cert-manager/cert-manager#5655, cert-manager/cert-manager#5546, cert-manager/cert-manager#5587, cert-manager/cert-manager#5570, cert-manager/cert-manager#5583, cert-manager/cert-manager#5597, cert-manager/cert-manager#5552, cert-manager/cert-manager#5613, cert-manager/cert-manager#5535

Bug/regression: cert-manager/cert-manager#5681, cert-manager/cert-manager#5663, cert-manager/cert-manager#5680, cert-manager/cert-manager#5674, cert-manager/cert-manager#5632, cert-manager/cert-manager#5584, cert-manager/cert-manager#5562, cert-manager/cert-manager#5591, cert-manager/cert-manager#5568, cert-manager/cert-manager#5619, cert-manager/cert-manager#5559, cert-manager/cert-manager#5702, cert-manager/cert-manager#5694, cert-manager/cert-manager#5691

Other: cert-manager/cert-manager#5703, cert-manager/cert-manager#5714

Known issues: cert-manager/cert-manager#5725

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@swghosh swghosh marked this pull request as draft April 6, 2023 12:08
@swghosh
Pull v1.11.0 Upstream manifests
d4b68c9 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
Bundle updates for 1.11
97098e1 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh swghosh marked this pull request as ready for review April 6, 2023 12:26
@swghosh swghosh changed the title [WIP] Rebase cert-manager v1.11 Rebase cert-manager v1.11 Apr 6, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@openshift-ci openshift-ci bot requested review from stlaz and TrilokGeer April 6, 2023 12:26
@swghosh
go.mod: update cert-manager dependency to v1.11
05d10ca 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
Fix overrides test failing due to new args
54b7460 
in v1.11 controller manifest:
"--acme-http01-solver-image=", "--max-concurrent-challenges="

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh swghosh changed the title Rebase cert-manager v1.11 CM-61: Rebase cert-manager v1.11 Apr 10, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

TODO:

  • skipRange in CSV

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Apr 11, 2023

/test e2e-operator

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 12, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

TODO:

  • skipRange in CSV
  • openshift/release PRs for operand image mirroring, CI pipeline change tags

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

thejasn
thejasn reviewed Apr 12, 2023
View reviewed changes
go.mod
@@ -3,36 +3,37 @@ module github.com/openshift/cert-manager-operator
go 1.19

require (
github.com/cert-manager/cert-manager v1.10.2
github.com/cert-manager/cert-manager v1.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be consuming our downstream fork here, right?

Copy link
Member Author

@swghosh swghosh Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a note of this during last rebase, but probably left it untouched as we've been doing it this way since before. Assuming we push the exact same commits to our fork does it really matter. However, if you suggest adding it we can, probably just a matter of another replace(...) block you're mentioning of right?

thejasn
thejasn reviewed Apr 12, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@thejasn
Copy link
Contributor

thejasn commented Apr 12, 2023

/assign

@swghosh
manual: v1.10.2 -> v1.11.0 more string replaces
1a74701 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh swghosh mentioned this pull request Apr 17, 2023
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Update deployment_overrides_tests to use default args explicitly
3f0b8ea 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@thejasn
Copy link
Contributor

thejasn commented Apr 18, 2023

@swghosh Can you update the description to contains all the go.mod changes being done along with the new versions. (library-go, controller-runtime, k8s deps, etc that were manually bumped)

@swghosh
Use skipRange <1.11.0 in csv
c8b2f5b 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

Rebase Checklist:

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

v1.11.0

v1.11.0 includes a drastic reduction in cert-manager's runtime memory usage, a slew of improvements to AKS integrations and various other tweaks, fixes and improvements, all towards cert-manager's goal of being the best way to handle certificates in modern Cloud Native applications.

Feature: cert-manager/cert-manager#5554, cert-manager/cert-manager#5638, cert-manager/cert-manager#5644, cert-manager/cert-manager#5646, cert-manager/cert-manager#5655, cert-manager/cert-manager#5546, cert-manager/cert-manager#5587, cert-manager/cert-manager#5570, cert-manager/cert-manager#5583, cert-manager/cert-manager#5597, cert-manager/cert-manager#5552, cert-manager/cert-manager#5613, cert-manager/cert-manager#5535

Bug/regression: cert-manager/cert-manager#5681, cert-manager/cert-manager#5663, cert-manager/cert-manager#5680, cert-manager/cert-manager#5674, cert-manager/cert-manager#5632, cert-manager/cert-manager#5584, cert-manager/cert-manager#5562, cert-manager/cert-manager#5591, cert-manager/cert-manager#5568, cert-manager/cert-manager#5619, cert-manager/cert-manager#5559, cert-manager/cert-manager#5702, cert-manager/cert-manager#5694, cert-manager/cert-manager#5691

Other: cert-manager/cert-manager#5703, cert-manager/cert-manager#5714

Known issues: cert-manager/cert-manager#5725

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-61 which is a valid jira issue.

In response to this:

[v1.11.0] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.11.0
go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go get sigs.k8s.io/controller-tools@v0.11.3 # latest
go get sigs.k8s.io/controller-runtime@v0.14.6 # latest
go get cloud.google.com/go/compute/metadata@latest # 0.2.3, added due to a conflict

go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

v1.11.0

v1.11.0 includes a drastic reduction in cert-manager's runtime memory usage, a slew of improvements to AKS integrations and various other tweaks, fixes and improvements, all towards cert-manager's goal of being the best way to handle certificates in modern Cloud Native applications.

Feature: cert-manager/cert-manager#5554, cert-manager/cert-manager#5638, cert-manager/cert-manager#5644, cert-manager/cert-manager#5646, cert-manager/cert-manager#5655, cert-manager/cert-manager#5546, cert-manager/cert-manager#5587, cert-manager/cert-manager#5570, cert-manager/cert-manager#5583, cert-manager/cert-manager#5597, cert-manager/cert-manager#5552, cert-manager/cert-manager#5613, cert-manager/cert-manager#5535

Bug/regression: cert-manager/cert-manager#5681, cert-manager/cert-manager#5663, cert-manager/cert-manager#5680, cert-manager/cert-manager#5674, cert-manager/cert-manager#5632, cert-manager/cert-manager#5584, cert-manager/cert-manager#5562, cert-manager/cert-manager#5591, cert-manager/cert-manager#5568, cert-manager/cert-manager#5619, cert-manager/cert-manager#5559, cert-manager/cert-manager#5702, cert-manager/cert-manager#5694, cert-manager/cert-manager#5691

Other: cert-manager/cert-manager#5703, cert-manager/cert-manager#5714

Known issues: cert-manager/cert-manager#5725

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member Author

swghosh commented Apr 18, 2023

@thejasn I've updated the PR description with all the relevant information.

@thejasn
Copy link
Contributor

thejasn commented Apr 18, 2023

/lgtm
/hold for pre-merge testing

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@xingxingxia
Copy link
Contributor

Adding qe-approved based on pre-merge test results in channel https://redhat-internal.slack.com/archives/C045YMPKR3M/p1682073637235019?thread_ts=1681844002.801959&cid=C045YMPKR3M
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 21, 2023
@thejasn
Copy link
Contributor

thejasn commented Apr 21, 2023

cc: @davemulford for px-approved
cc: @xenolinux for docs-approved

@thejasn
Copy link
Contributor

thejasn commented Apr 21, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2023
@xenolinux
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 21, 2023
@davemulford
Copy link

I don't see anything major in the upstream docs about upgrading to this version.
/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2023

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 3b16520 into openshift:master Apr 21, 2023
This was referenced Apr 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejasn thejasn thejasn left review comments

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@stlaz stlaz Awaiting requested review from stlaz

@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

Assignees

@thejasn thejasn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@swghosh @openshift-ci-robot @thejasn @xingxingxia @xenolinux @davemulford