Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert-manager: Add supplement image mirroring for v1.11.0 #38295

Merged

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Apr 13, 2023

Add mirroring for cert-manager v1.11.0 controller, webhook, cainjector images from upstream to our ci:

  • quay.io/jetstack/cert-manager-controller:v1.11.0 -> registry.ci.openshift.org/ci/cert-manager-controller:v1.11.0
  • quay.io/jetstack/cert-manager-cainjector:v1.11.0 -> registry.ci.openshift.org/ci/cert-manager-cainjector:v1.11.0
  • quay.io/jetstack/cert-manager-webhook:v1.11.0 -> registry.ci.openshift.org/ci/cert-manager-webhook:v1.11.0

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
Copy link
Member Author

swghosh commented Apr 13, 2023

cc: @thejasn

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 13, 2023
@openshift-ci-robot
Copy link
Contributor

@swghosh: no rehearsable tests are affected by this change

@smg247
Copy link
Member

smg247 commented Apr 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@swghosh
Copy link
Member Author

swghosh commented Apr 13, 2023

@smg247 we no longer need to separately specify mirroring for arm64, right?
As we used to do it previously in core-services/image-mirroring-arm64/mapping_supplemental_ci_images_ci eg.
https://github.com/openshift/release/pull/35771/files#diff-279e7d90586cf09c91ecfa79afe9430f74beb60050e64cf70e0bd7db30172b94R44

@smg247
Copy link
Member

smg247 commented Apr 13, 2023

Correct. That file, and process no longer exist.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a8a9d08 into openshift:master Apr 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 13, 2023

@swghosh: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_supplemental_ci_images_ci using file core-services/image-mirroring/supplemental-ci-images/mapping_supplemental_ci_images_ci

In response to this:

Add mirroring for cert-manager v1.11.0 controller, webhook, cainjector images from upstream to our ci:

  • quay.io/jetstack/cert-manager-controller:v1.11.0 -> registry.ci.openshift.org/ci/cert-manager-controller:v1.11.0
  • quay.io/jetstack/cert-manager-cainjector:v1.11.0 -> registry.ci.openshift.org/ci/cert-manager-cainjector:v1.11.0
  • quay.io/jetstack/cert-manager-webhook:v1.11.0 -> registry.ci.openshift.org/ci/cert-manager-webhook:v1.11.0

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh swghosh changed the title cert-manager: Add supplement image mirroring for v1.10.2 cert-manager: Add supplement image mirroring for v1.11.0 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants