-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: introduce path-namespace CLI argument #38
*: introduce path-namespace CLI argument #38
Conversation
cce7ba5
to
2ebe470
Compare
All comments addressed @lucab, PTAL. |
This gives the option to prefix all public paths with a given namespace.
/lgtm |
@lucab: changing LGTM is restricted to assignees, and only openshift/cincinnati repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/refresh |
/lgtm |
@lucab: changing LGTM is restricted to assignees, and only openshift/cincinnati repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/refresh |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucab, steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(for reference, my previous reviews were rejected due to the same permission mismatch as openshift/installer#588 (comment)) |
This gives the option to prefix all paths with a given namespace.
Contributes to https://jira.coreos.com/browse/CORS-957.