Read OpenStack creds from standard paths #588
Conversation
openshift-ci-robot
added
the
size/XXL
|
/test e2e-openstack |
flaper87
force-pushed
the
openstack-creds-read
branch
from
a93de30
to
e7c66f4
Compare
|
/test e2e-openstack |
|
The failure in the /me working on it |
|
+1 was discussing this issue today with @tomassedovic and we mentioned it'd be better to avoid paths completely in the installer and rely on gophercloud instead, thanks for working on it! |
flaper87
force-pushed
the
openstack-creds-read
branch
2 times, most recently
from
34ff8bb
to
2859434
Compare
|
/test e2e-openstack |
|
FWIW, the |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
|
/test e2e-openstack |
|
/test e2e-aws |
|
Can you split this up into multiple commits? Vendoring operations should be in their own commit. Take a look at the repo's history for a sense of how we split things and write the commit messages. |
flaper87
force-pushed
the
openstack-creds-read
branch
2 times, most recently
from
ccd142f
to
4da10b4
Compare
|
@crawford Thanks for the review! I've split the commits |
|
/assign @tomassedovic |
|
@tomassedovic: GitHub didn't allow me to assign the following users: tomassedovic. Note that only openshift members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @tomassedovic |
|
@tomassedovic: GitHub didn't allow me to assign the following users: tomassedovic. Note that only openshift members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Strange. I am part of the openshift org. Guess I'm not a collaborator? |
|
/lgtm |
|
@tomassedovic: changing LGTM is restricted to assignees, and only openshift/installer repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Maybe he needs to be in a team associated with this repo? From here:
GitHub will auto-complete the other |
flaper87
force-pushed
the
openstack-creds-read
branch
from
36917d5
to
be5c247
Compare
We're all part of this team: https://github.com/orgs/openshift/teams/team-openstack-cloud-provider I'll verify whether that team is associated with this repo. If so, then it's something related to @tomassedovic account as you said :D |
|
@flaper87: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
flaper87
force-pushed
the
openstack-creds-read
branch
from
be5c247
to
4f5658a
Compare
|
According to https://github.com/orgs/openshift/teams/team-openstack-cloud-provider/repositories the team is not associated with this repo. @smarterclayton can you please add this repo to our team? While you're at it, it'd be great to also add release, MCO, and MAO and other repos you think we might need to provide reviews on :) |
|
Let's try again /approve |
|
@flaper87: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Smart bot, makes sense! 😄 |
|
/assign @hardys |
|
/assign @tomassedovic |
|
@flaper87: GitHub didn't allow me to assign the following users: tomassedovic. Note that only openshift members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Let me try this one more time /lgtm |
|
@tomassedovic: changing LGTM is restricted to assignees, and only openshift/installer repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gophercloud and gophercloud utils are a library and a set of utilities that provide common functionality to interact with OpenStack clouds, configurations, etc. We need these libraries to manage OpenStack configs as it's done upstream and for future work like adding an OpenStack destroyer.
OpenStack creds cold be in 3 different paths (etc, home config and current dir). Instead of re-implementing the logic to find and read the clouds.yaml file, we should use gophercloud which is the standard go library for OpenStack. Note that deployments on OpenStack are currently broken unless there's a clouds.yaml under /etc/openstack. Fixes openshift#550
flaper87
force-pushed
the
openstack-creds-read
branch
from
4f5658a
to
40e438c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, hardys, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@petr-muller: GitHub didn't allow me to assign the following users: tomassedovic. Note that only openshift members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @tomassedovic |
|
Hooray for both the merge and @tomassedovic becoming assignable ;). For future reference, @tomassedovic do you know what changed for your to become assignable? |
OpenStack creds cold be in 3 different paths (etc, home config and
current dir). Instead of re-implementing the logic to find and read the
clouds.yaml file, we should use gophercloud which is the standard
go library for OpenStack.
Note that deployments on OpenStack are currently broken unless there's
a
clouds.yamlunder/etc/openstack.Fixes #550
cc @tomassedovic @hardys @russellb @sallyom