Webpack isn't treeshaking library bundles

[redallen]

With only [babel-loader] pointed at an entry: index.js, Webpack will treeshake harmony imports like import { Button } from 'patternfly-react'; and not include the entirety of the patternfly-react project in it's bundle like it is currently:

As a few examples, patternfly-react's Wizard is included, along with @patternfly/react-core's Text component.

Really, we should expect a bundle more like:

That doesn't include these components.

This will require removing the two require('patternfly-react').then(m => m.Component) in the project as well, since that forces Webpack to bundle the entire module.

[spadgett]

https://jira.coreos.com/browse/CONSOLE-1651

[spadgett]

/kind bug

[spadgett]

I believe this is specific to the kubevirt plugin, likely kubevirt-web-ui-components. All of the PF3 components drop out of the main vendor bundle when disabling the kubevirt plugin.

cc @vojtechszocs

Current master:

With kubevirt plugin disabled:

[spadgett]

@dgutride fyi

[spadgett]

@mareklibra fyi

[redallen]

Correct, it is due to kubevirt-web-ui-components. That's why I went upstream to provide esm exports for it, and am now using them in #2232 .

[vojtechszocs]

@spadgett @redallen @mareklibra @jelkosz

Correct, it is due to kubevirt-web-ui-components.

This ^^ dependency was added due to migrating code from kubevirt/web-ui fork to Console monorepo, impacting following packages:

• frontend/packages/kubevirt-plugin
• frontend/packages/console-shared

After 4.2 gets released and master branch re-opens for development, the KubeVirt group should dedicate some sprints to migrating kubevirt-web-ui-components code over to Console monorepo, resulting in eventual removal of this dependency as well as the fork itself.

As a result, any kubevirt-xxx chunks (as shown in #2394) should become smaller. The whole dependency sub-tree starting at kubevirt-web-ui-components should be cut off entirely.

[spadgett]

Fixed by the following PRs:

#2372
#2383
#2595

/close

[openshift-ci-robot]

@spadgett: Closing this issue.

In response to this:

Fixed by the following PRs:

#2372
#2383
#2595

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.