Don't use AsyncComponent PF3 Switch #2383
Conversation
|
@spadgett: GitHub didn't allow me to request PR reviews from the following users: redallen. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/S
|
/retest |
|
/hold |
spadgett
force-pushed
the
remove-async-switch
branch
from
c853ec6
to
cbefdd9
Compare
|
I didn't mean to change the metal3 import. @alecmerdler another look? /hold cancel |
| @@ -6,6 +6,7 @@ import { safeDump } from 'js-yaml'; | |||
| import * as _ from 'lodash-es'; | |||
| import { PropertyPath } from 'lodash'; | |||
| import * as classNames from 'classnames'; | |||
| import { Switch } from 'patternfly-react'; | |||
There was a problem hiding this comment.
Is there a reason to prefer importing from patternfly-react, rather than @patternfly/react-core(already imported in this file)?
There was a problem hiding this comment.
One is PF3. The other is PF4. We should eventually migrate to the PF4 component, but it’s not a drop in replacement
This creates a separate bundle with all of PF3 and breaks tree-shaking. Removing the AsyncComponent doesn't increase the main vendor bundle size.
spadgett
force-pushed
the
remove-async-switch
branch
from
cbefdd9
to
2ca2e37
Compare
|
Rebased |
|
@alecmerdler ptal |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
This creates a separate bundle with all of PF3 and breaks tree-shaking.
Removing the AsyncComponent doesn't increase the main vendor bundle size.
Here is the PF3 chunk that this change removes:
Credit to @redallen for tracking this down!
/cc @alecmerdler @redallen