kubevirt: Add Status column to VmList #1689

mareklibra · 2019-06-10T13:36:52Z

The State column is added into VmList page.

Depends on:

TODO:

extension point for filters - wip Add extension for list-page filters #1693, Add support for custom table filters #1735
VM Status filters

openshift-ci-robot · 2019-06-10T13:37:06Z

Hi @mareklibra. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mareklibra · 2019-06-13T12:54:40Z

frontend/packages/_plugin-style.scss

@@ -0,0 +1,4 @@
+/* Styles of all active plugins */
+
+@import "kubevirt-plugin/src/style";


Plugin's entrypoint can import style, so this will be removed

spadgett · 2019-06-13T13:02:09Z

frontend/packages/kubevirt-plugin/src/components/vm.tsx

-    {/* TODO(mlibra): migrate VM status in a follow-up
-  <ColHead {...props} className={mainRowSize} sortField="spec.running">State</ColHead>
-  */}
+    <ColHead {...props} className={mainRowSize} sortField="spec.running">


We should update to PF4 tables. See #1465 and follow on #1707.

ok, this is wip in #1758

frontend/packages/kubevirt-plugin/src/_style.scss

frontend/packages/kubevirt-plugin/src/components/constants.js

vojtechszocs · 2019-06-14T18:58:21Z

frontend/packages/kubevirt-plugin/src/types.ts

@@ -0,0 +1,60 @@
+import { K8sResourceKind, ObjectMetadata } from '@console/internal/module/k8s';


Nit-pick: I'd use a more specific file name, i.e. k8s-types or similar.

frontend/public/style.scss

mareklibra · 2019-06-19T12:20:08Z

Rebased as master and #1682 were changed.

jtomasek · 2019-06-20T06:49:09Z

/ok-to-test

mareklibra · 2019-06-21T07:51:58Z

@spadgett , can you please have a look?

jtomasek · 2019-06-21T08:13:50Z

frontend/packages/kubevirt-plugin/src/components/vms/vm.tsx

+
+const filters = [
+  {
+    type: kubevirtTableFilters.VmStatus.type,


Wouldn't it be simpler to define whole vmStatusFilter object in kubevirtTableFilters, export it and just pass it in rowFilters prop?

See 768bb67

good idea, thanks. I've moved Filter type to @console/shared.

jtomasek · 2019-06-25T12:05:50Z

frontend/packages/kubevirt-plugin/src/components/vms/vm.tsx

 };

+const VMRowFirehose = ({ obj: vm }: React.ComponentProps<typeof ResourceRow>) => {


Note that once this #1758 merges, it will be possible to pass resources to MultiListPage so you could use that to fetch migrations and pods and avoid connecting each row separately.

Yes, that will be much easier. I don't have any numbers, but I believe this is not a blocker for this PR as the performance is not significantly hit by wrapping every row.

I would prefer to wait for #1758 to merge (probably today) as the new approach is more performant and does use only few websockets instead of n.

mareklibra · 2019-06-26T07:33:08Z

/test e2e-aws

atiratree · 2019-06-26T14:42:45Z

#1758 was merged, please see #1761 on how to pass additional resources

mareklibra · 2019-06-27T07:41:24Z

Rebased on top of #1761 and #1839, just the last commit is relevant.

mareklibra · 2019-06-28T07:04:04Z

Rebased as #1761 is merged now.

mareklibra · 2019-06-28T10:30:27Z

/test frontend
/test e2e-aws-console
/test e2e-aws-console-olm

jelkosz · 2019-07-01T07:41:09Z

/test frontend
/test e2e-aws-console
/test backend

rawagner · 2019-07-02T07:59:39Z

all required PRs are now merged and i also rebased on master.
@suomiy please take a look

atiratree · 2019-07-02T10:07:18Z

/lgtm

openshift-ci-robot · 2019-07-02T10:07:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [mareklibra,suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2019

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2019

openshift-ci-robot requested review from spadgett and vojtechszocs June 10, 2019 13:37

mareklibra mentioned this pull request Jun 11, 2019

Add extension for list-page filters #1693

Closed

mareklibra commented Jun 13, 2019

View reviewed changes

spadgett reviewed Jun 13, 2019

View reviewed changes

vojtechszocs suggested changes Jun 14, 2019

View reviewed changes

spadgett added this to the v4.2 milestone Jun 14, 2019

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2019

mareklibra changed the title ~~WIP: kubevirt: Add Status column to VmList~~ kubevirt: Add Status column to VmList Jun 19, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2019

mareklibra mentioned this pull request Jun 19, 2019

Kubevirt: port VM list to PF4 Table #1758

Merged

2 tasks

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2019

jtomasek reviewed Jun 21, 2019

View reviewed changes

mareklibra mentioned this pull request Jun 25, 2019

Add host list filters #1786

Merged

jtomasek reviewed Jun 25, 2019

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2019

mareklibra mentioned this pull request Jun 27, 2019

console-shared: add Filter type #1839

Merged

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2019

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2019

kubevirt: Add Status column to VmList

d484081

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019

openshift-ci-robot assigned atiratree Jul 2, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019

rawagner mentioned this pull request Jul 2, 2019

Add VMs to Inventory card #1883

Merged

openshift-merge-robot merged commit 71f40c5 into openshift:master Jul 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubevirt: Add Status column to VmList #1689

kubevirt: Add Status column to VmList #1689

mareklibra commented Jun 10, 2019 •

edited

Loading

openshift-ci-robot commented Jun 10, 2019

mareklibra Jun 13, 2019 •

edited

Loading

spadgett Jun 13, 2019

mareklibra Jun 26, 2019

vojtechszocs Jun 14, 2019

mareklibra commented Jun 19, 2019

jtomasek commented Jun 20, 2019

mareklibra commented Jun 21, 2019

jtomasek Jun 21, 2019

jtomasek Jun 21, 2019 •

edited

Loading

mareklibra Jun 25, 2019

jtomasek Jun 25, 2019

mareklibra Jun 26, 2019

atiratree Jun 26, 2019

mareklibra commented Jun 26, 2019

atiratree commented Jun 26, 2019

mareklibra commented Jun 27, 2019 •

edited

Loading

mareklibra commented Jun 28, 2019

mareklibra commented Jun 28, 2019

jelkosz commented Jul 1, 2019

rawagner commented Jul 2, 2019

atiratree commented Jul 2, 2019

openshift-ci-robot commented Jul 2, 2019

		@@ -0,0 +1,4 @@
		/* Styles of all active plugins */

		@import "kubevirt-plugin/src/style";

		@@ -0,0 +1,60 @@
		import { K8sResourceKind, ObjectMetadata } from '@console/internal/module/k8s';

		};

		const VMRowFirehose = ({ obj: vm }: React.ComponentProps<typeof ResourceRow>) => {

kubevirt: Add Status column to VmList #1689

kubevirt: Add Status column to VmList #1689

Conversation

mareklibra commented Jun 10, 2019 • edited Loading

openshift-ci-robot commented Jun 10, 2019

mareklibra Jun 13, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mareklibra commented Jun 19, 2019

jtomasek commented Jun 20, 2019

mareklibra commented Jun 21, 2019

Choose a reason for hiding this comment

jtomasek Jun 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mareklibra commented Jun 26, 2019

atiratree commented Jun 26, 2019

mareklibra commented Jun 27, 2019 • edited Loading

mareklibra commented Jun 28, 2019

mareklibra commented Jun 28, 2019

jelkosz commented Jul 1, 2019

rawagner commented Jul 2, 2019

atiratree commented Jul 2, 2019

openshift-ci-robot commented Jul 2, 2019

mareklibra commented Jun 10, 2019 •

edited

Loading

mareklibra Jun 13, 2019 •

edited

Loading

jtomasek Jun 21, 2019 •

edited

Loading

mareklibra commented Jun 27, 2019 •

edited

Loading