Kubevirt: port VM list to PF4 Table

[atiratree]

depends on

• VM Detail: add Events tab  #1739 or Kubevirt VmDetails #1682
• TypeScript Enhancements #1757

[openshift-ci-robot]

Hi @suomiy. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mareklibra]

@suomiy , I think this is better to stack on #1689 or at least #1682

[mareklibra]

@suomiy , can you please provide reasoning behind this new project/dependency?

[atiratree]

as said in #1731, this is to add TS definitions of kubevirt objects

[rawagner]

Could we do it without adding this dependency and maybe revisit it later ? It will just slow down merging the PRs and we dont really have a time to waste.

[atiratree]

@suomiy , I think this is better to stack on #1689 or at least #1682

this depends on #1682 or #1739 (whichever comes first)

[mareklibra]

Please note, #1682 is merged now.
I like the idea of generating typescript based on API, esp. to deal with complexity and conformity. Moreover the API is changing over-time, we are i.e. close to v1.

However, the project should become official part of kubevirt first, imo.

As @rawagner wrote, we need to concentrate on 4.2 features as the top priority now and introduction of a similar dependency sounds like splitting of our effort. I think it's more safe to re-evaluate in post-4.2 timeframe.

[atiratree]

Please note, #1682 is merged now.
I like the idea of generating typescript based on API, esp. to deal with complexity and conformity. Moreover the API is changing over-time, we are i.e. close to v1.

However, the project should become official part of kubevirt first, imo.

As @rawagner wrote, we need to concentrate on 4.2 features as the top priority now and introduction of a similar dependency sounds like splitting of our effort. I think it's more safe to re-evaluate in post-4.2 timeframe.

It depends. It can be quite fast if we move it to console repo. Moved the discussion to #1773

[atiratree]

removed dependency on the types (#1773)

[jelkosz]

/ok-to-test

[atiratree]

fixed

[rawagner]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [rawagner,suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment