-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-39305: log only deprecated api requests #2067
Conversation
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
New commits here have CI still running, but 15019c4 had some runs complete, and it already looks pretty good in terms of having fewer APIRequestCount resources in this presubmit run's must-gather: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_kubernetes/2067/pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial/1828863952012972032/artifacts/e2e-aws-ovn-serial/gather-must-gather/artifacts/must-gather.tar | tar -tvz | grep apirequestcounts/
-rw------- 1003380000/root 6599 2024-08-28 15:09 registry-build03-ci-openshift-org-ci-op-rxqnq9yz-stable-sha256-18f723c850991a8c1bb9cfdd2b88323047bb24102fcddc248f7372ff4d117cca/cluster-scoped-resources/apiserver.openshift.io/apirequestcounts/flowschemas.v1beta1.flowcontrol.apiserver.k8s.io.yaml
-rw------- 1003380000/root 6615 2024-08-28 15:09 registry-build03-ci-openshift-org-ci-op-rxqnq9yz-stable-sha256-18f723c850991a8c1bb9cfdd2b88323047bb24102fcddc248f7372ff4d117cca/cluster-scoped-resources/apiserver.openshift.io/apirequestcounts/prioritylevelconfigurations.v1beta1.flowcontrol.apiserver.k8s.io.yaml |
@sanchezl: This pull request references Jira Issue OCPBUGS-39305, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sanchezl: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
(cancel at will)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, sanchezl, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@sanchezl: Can not set label backports/validated-commits: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sanchezl: Can not set label backports/unvalidated-commits: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bertinatto Would you mind taking a look and take care of the unvalidated comment label? Thanks. |
Should this be squashed with 78c9d187348f? If so (for the next ones), please use the same commit message so that we know this needs to be squashed. /remove-label backports/unvalidated-commits |
/cherry-pick release-4.17 release-4.16 |
@sanchezl: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sanchezl: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@sanchezl: Jira Issue OCPBUGS-39305: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-39305 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sanchezl: new pull request created: #2111 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
TRT-1867: Revert #2067 "OCPBUGS-39305: log only deprecated api requests"
No description provided.