Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-39305: UPSTREAM: <carry>: log only deprecated api requests #2113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-39305: UPSTREAM: <carry>: log only deprecated api requests #2113

wants to merge 1 commit into from

Conversation

dgrisonnet
Copy link
Member

Unrevert #2067.

This PR needs openshift/cluster-authentication-operator#712 to go in before merging as well as a green pass on /payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 15, 2024
@openshift-ci-robot
Copy link

@dgrisonnet: This pull request references Jira Issue OCPBUGS-39305, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Unrevert #2067.

This PR needs openshift/cluster-authentication-operator#712 to go in before merging as well as a green pass on /payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 15, 2024
@openshift-ci-robot
Copy link

@dgrisonnet: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested a review from gangwgr October 15, 2024 12:08
@dgrisonnet
Copy link
Member Author

Holding based on the requirements listed in the PR's description.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@openshift-ci openshift-ci bot requested review from bertinatto and tkashem October 15, 2024 12:10
@sanchezl
Copy link

/payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 15, 2024

@sanchezl: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e080d40-8b0b-11ef-897b-9459f19f2d80-0

@wallylewis
Copy link

/retest

@dgrisonnet
Copy link
Member Author

/retest
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 11, 2024

@dgrisonnet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dgrisonnet
Copy link
Member Author

/assign @p0lyn0mial

we will also need to override the commit label

@bertinatto
Copy link
Member

/assign @p0lyn0mial

we will also need to override the commit label

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/lgtm

And hold until for a green run of the upgrade job:

/hold

/payload periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Nov 12, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@bertinatto
Copy link
Member

/payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 12, 2024

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a52eb220-a0f4-11ef-8640-6aca085df48c-0

@dgrisonnet
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

@dgrisonnet: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e84b7370-b19f-11ef-8e59-f96d498c5274-0

@dgrisonnet
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

@dgrisonnet: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b5144560-b1bb-11ef-9e8d-d868412a99b4-0

@dgrisonnet
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 4, 2024

@dgrisonnet: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebbf7930-b21b-11ef-971d-51dc89ad7ac0-0

@sanchezl
Copy link

/payload-job periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

@sanchezl: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/98a08810-b70d-11ef-9685-499a407f52e9-0

@bertinatto
Copy link
Member

/payload-job periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb120fc0-bd46-11ef-87aa-9e4e0d687579-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gangwgr gangwgr Awaiting requested review from gangwgr

@bertinatto bertinatto Awaiting requested review from bertinatto

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@bertinatto bertinatto

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dgrisonnet @openshift-ci-robot @sanchezl @wallylewis @bertinatto @p0lyn0mial