OCPBUGS-11486: fix: correctly determine master nodes by label for SNO

[jakobmoellerdev]

Uses https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-control-plane to discover master nodes instead of simply checking if there is one node.

also adds tests for various node configurations in the Wild and moves the resolve logic out of main.go

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-11486, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Uses https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-control-plane to discover master nodes instead of simply checking if there is one node.

also adds tests for various node configurations in the Wild and moves the resolve logic out of main.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/jira refresh

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-11486, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-roche]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jeff-roche]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Merging #376 (cc4ef90) into main (a962b90) will increase coverage by 40.13%.
Report is 6 commits behind head on main.
The diff coverage is 57.57%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #376       +/-   ##
===========================================
+ Coverage   16.59%   56.73%   +40.13%     
===========================================
  Files          24       25        +1     
  Lines        2061     2094       +33     
===========================================
+ Hits          342     1188      +846     
+ Misses       1693      822      -871     
- Partials       26       84       +58     

Files Changed	Coverage Δ
pkg/cluster/leaderelection.go	57.57% <57.57%> (ø)

... and 11 files with indirect coverage changes

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-11486: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#370
• openshift/lvm-operator#376

Jira Issue OCPBUGS-11486 has been moved to the MODIFIED state.

In response to this:

Uses https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-control-plane to discover master nodes instead of simply checking if there is one node.

also adds tests for various node configurations in the Wild and moves the resolve logic out of main.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.