-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-11486: fix: passthrough unified LE settings to all controllers #377
OCPBUGS-11486: fix: passthrough unified LE settings to all controllers #377
Conversation
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-11486, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
===========================================
+ Coverage 16.59% 57.06% +40.46%
===========================================
Files 24 25 +1
Lines 2061 2110 +49
===========================================
+ Hits 342 1204 +862
+ Misses 1693 822 -871
- Partials 26 84 +58
|
2554fc1
to
1e847f3
Compare
/test ci/prow/lvm-operator-e2e-aws |
@jakobmoellerdev: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test lvm-operator-e2e-aws |
/test images |
/test lvm-operator-e2e-aws |
Signed-off-by: jakobmoellerdev <jmoller@redhat.com>
1e847f3
to
acf2f73
Compare
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, jeff-roche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jakobmoellerdev: Jira Issue OCPBUGS-11486: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-11486 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This passes all leader election settings to the controllers so that all controllers have unified Leader Election Configuration.