Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-11486: fix: passthrough unified LE settings to all controllers #377

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

This passes all leader election settings to the controllers so that all controllers have unified Leader Election Configuration.

@jakobmoellerdev jakobmoellerdev changed the title fix: passthrough unified LE settings to all controllers OCPBUGS-11486: fix: passthrough unified LE settings to all controllers Aug 7, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 7, 2023
@openshift-ci-robot
Copy link

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-11486, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This passes all leader election settings to the controllers so that all controllers have unified Leader Election Configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2023
@openshift-ci openshift-ci bot requested review from jerpeter1 and qJkee August 7, 2023 09:40
@codecov-commenter
Copy link

Codecov Report

Merging #377 (2554fc1) into main (a962b90) will increase coverage by 40.46%.
Report is 8 commits behind head on main.
The diff coverage is 76.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #377       +/-   ##
===========================================
+ Coverage   16.59%   57.06%   +40.46%     
===========================================
  Files          24       25        +1     
  Lines        2061     2110       +49     
===========================================
+ Hits          342     1204      +862     
+ Misses       1693      822      -871     
- Partials       26       84       +58     
Files Changed Coverage Δ
pkg/cluster/leaderelection.go 57.57% <57.57%> (ø)
controllers/lvmcluster_controller.go 60.00% <100.00%> (+60.00%) ⬆️
controllers/topolvm_controller.go 94.14% <100.00%> (+94.14%) ⬆️

... and 9 files with indirect coverage changes

@jakobmoellerdev jakobmoellerdev force-pushed the OCPBUGS-11486-passthrough branch from 2554fc1 to 1e847f3 Compare August 7, 2023 10:12
@jakobmoellerdev
Copy link
Contributor Author

/test ci/prow/lvm-operator-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

@jakobmoellerdev: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index-lvm-operator-bundle
  • /test images
  • /test lvm-operator-e2e-aws
  • /test unit-test
  • /test verify

Use /test all to run all jobs.

In response to this:

/test ci/prow/lvm-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@jakobmoellerdev
Copy link
Contributor Author

/test images

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

Signed-off-by: jakobmoellerdev <jmoller@redhat.com>
@jakobmoellerdev jakobmoellerdev force-pushed the OCPBUGS-11486-passthrough branch from 1e847f3 to acf2f73 Compare August 9, 2023 12:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qJkee
Copy link
Contributor

qJkee commented Aug 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@jeff-roche
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@jeff-roche jeff-roche merged commit fc2a919 into openshift:main Aug 10, 2023
@openshift-ci-robot
Copy link

@jakobmoellerdev: Jira Issue OCPBUGS-11486: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11486 has been moved to the MODIFIED state.

In response to this:

This passes all leader election settings to the controllers so that all controllers have unified Leader Election Configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants