-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-605: Allow recovering from existing volume groups #448
Conversation
@suleymanakbas91: This pull request references OCPVE-605 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
687972c
to
36683ce
Compare
/hold |
36683ce
to
e995066
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 56.77% 56.88% +0.11%
==========================================
Files 22 22
Lines 1728 1735 +7
==========================================
+ Hits 981 987 +6
Misses 626 626
- Partials 121 122 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2 small comments, other than that LGTM. pretty complex flow change, so not sure if i got all the cases
e995066
to
37bab66
Compare
Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
37bab66
to
f1f4092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@suleymanakbas91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR allows LVMS to pick up and use an existing volume group if it has the same name as the reconciled LVMVolumeGroup name.