Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-605: Allow recovering from existing volume groups #448

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

suleymanakbas91
Copy link
Contributor

This PR allows LVMS to pick up and use an existing volume group if it has the same name as the reconciled LVMVolumeGroup name.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2023

@suleymanakbas91: This pull request references OCPVE-605 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR allows LVMS to pick up and use an existing volume group if it has the same name as the reconciled LVMVolumeGroup name.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@suleymanakbas91
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #448 (f1f4092) into main (61e044a) will increase coverage by 0.11%.
Report is 2 commits behind head on main.
The diff coverage is 55.17%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   56.77%   56.88%   +0.11%     
==========================================
  Files          22       22              
  Lines        1728     1735       +7     
==========================================
+ Hits          981      987       +6     
  Misses        626      626              
- Partials      121      122       +1     
Files Coverage Δ
internal/controllers/vgmanager/devices.go 80.17% <100.00%> (ø)
internal/controllers/vgmanager/controller.go 35.63% <53.57%> (+1.02%) ⬆️

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 small comments, other than that LGTM. pretty complex flow change, so not sure if i got all the cases

internal/controllers/vgmanager/controller.go Show resolved Hide resolved
internal/controllers/vgmanager/controller_test.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2023
Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@suleymanakbas91
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 1946d91 into openshift:main Oct 13, 2023
@suleymanakbas91 suleymanakbas91 deleted the recover-from-vg branch October 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants