Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-47457,OCPBUGS-47458: crio: drop crun subcgroup #4768

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-47457,OCPBUGS-47458: crio: drop crun subcgroup #4768

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4765

/assign haircommander

@haircommander
crio: drop crun subcgroup
9305086 
historically crun has run with a subcgroup to allow it to own the cgroup configuration of a container
this is more idiomatic with systemd's single owner rule.

The problem is the subcgroup means there is an extra cgroup for cadvisor to read metrics for, so
moving to crun by default actually increases cpu usage. Dropping the subcgroup (with a new cri-o knob and
this annotation) fixes this regression.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 19, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-45928 has been cloned as Jira Issue OCPBUGS-47457. Will retitle bug to link to clone.

Jira Issue OCPBUGS-46531 has been cloned as Jira Issue OCPBUGS-47458. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-47457,OCPBUGS-47458: crio: drop crun subcgroup

In response to this:

This is an automated cherry-pick of #4765

/assign haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-45928,OCPBUGS-46531: crio: drop crun subcgroup [release-4.18] OCPBUGS-47457,OCPBUGS-47458: crio: drop crun subcgroup Dec 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 19, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-47457, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-47458, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #4765

/assign haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kwilczynski and mtrmac December 19, 2024 14:48
sohankunkerkar
sohankunkerkar approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@haircommander
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 19, 2024
@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-47457, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-45928 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-45928 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @cpmeadors

This pull request references Jira Issue OCPBUGS-47458, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-46531 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-46531 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @cpmeadors

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 19, 2024
@openshift-ci openshift-ci bot requested a review from cpmeadors December 19, 2024 16:57
@haircommander
Copy link
Member

/retest

@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski, openshift-cherrypick-robot, sohankunkerkar
Once this PR has been reviewed and has the lgtm label, please ask for approval from haircommander. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sohankunkerkar
Copy link
Member

You need to fix https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_machine-config-operator/4768/pull-ci-openshift-machine-config-operator-release-4.18-unit/1869800099165507584

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview 9305086 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-zones 9305086 link false /test e2e-vsphere-ovn-zones
ci/prow/unit 9305086 link true /test unit
ci/prow/okd-scos-e2e-aws-ovn 9305086 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change 9305086 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn 9305086 link true /test e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-upi-zones 9305086 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-aws-ovn-upgrade-out-of-change 9305086 link false /test e2e-aws-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kannon92
Copy link
Contributor

/hold

#4770

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@jpeimer jpeimer mentioned this pull request Dec 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

@mtrmac mtrmac Awaiting requested review from mtrmac

@cpmeadors cpmeadors Awaiting requested review from cpmeadors

Assignees

@kwilczynski kwilczynski

@haircommander haircommander

@sohankunkerkar sohankunkerkar

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @haircommander @kwilczynski @sohankunkerkar @kannon92