Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1926: Revert #4765 "crio: drop crun subcgroup" #4770

Merged
merged 1 commit into from
Dec 20, 2024
Merged

TRT-1926: Revert #4765 "crio: drop crun subcgroup" #4770

merged 1 commit into from
Dec 20, 2024
+0 −2

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Dec 20, 2024 •
edited by openshift-ci bot
Loading

Reverts #4765 ; tracked by TRT-1926

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

We are seeing cri-o panic in jobs after this and the cri-o package bump landed, which seems to be impacting nodes and causing some tests to fail.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.19 blocking nightly

CC: @haircommander

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#4765 from haircommander/drop-sub…
9e8ecf4 
…cgroup"

This reverts commit c711e64, reversing
changes made to 36e2d57.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 20, 2024
@openshift-ci-robot
Copy link
Contributor

@stbenjam: This pull request explicitly references no jira issue.

In response to this:

Reverts #4765 ; tracked by NO-JIRA

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Tentative revert to debug nodes going unready

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @haircommander

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam stbenjam changed the title NO-JIRA: Revert #4765 "OCPBUGS-45928,OCPBUGS-46531: crio: drop crun subcgroup" [WIP] NO-JIRA: Revert #4765 "OCPBUGS-45928,OCPBUGS-46531: crio: drop crun subcgroup" Dec 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2024
@stbenjam
Copy link
Member Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade 10

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ec613c60-bedd-11ef-9cbb-90502c79f969-0

@stbenjam
Copy link
Member Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade 10

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ef8c8bb0-bedd-11ef-8abc-9718fdbf7b63-0

@stbenjam stbenjam changed the title [WIP] NO-JIRA: Revert #4765 "OCPBUGS-45928,OCPBUGS-46531: crio: drop crun subcgroup" TRT-1926: Revert #4765 "OCPBUGS-45928,OCPBUGS-46531: crio: drop crun subcgroup" Dec 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2024 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1926 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Reverts #4765 ; tracked by NO-JIRA

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Tentative revert to debug nodes going unready

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @haircommander

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam stbenjam changed the title TRT-1926: Revert #4765 "OCPBUGS-45928,OCPBUGS-46531: crio: drop crun subcgroup" TRT-1926: Revert #4765 "crio: drop crun subcgroup" Dec 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2024 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1926 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Reverts #4765 ; tracked by TRT-1926

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

We are seeing cri-o panic in jobs after this and the cri-o package bump landed, which seems to be impacting nodes and causing some tests to fail.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.19 blocking nightly

CC: @haircommander

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2024 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1926 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Reverts #4765 ; tracked by TRT-1926

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

We are seeing cri-o panic in jobs after this and the cri-o package bump landed, which seems to be impacting nodes and causing some tests to fail.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.19 blocking nightly

CC: @haircommander

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kannon92 kannon92 mentioned this pull request Dec 20, 2024
Open
@stbenjam
Copy link
Member Author

/test unit

@haircommander
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@rphillips
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f0d60f5 into openshift:master Dec 20, 2024
18 of 20 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202412202037.p0.gf0d60f5.assembly.stream.el9.
All builds following this will include this PR.

@jpeimer
Copy link

jpeimer commented Dec 22, 2024

Hello @stbenjam, is there a plan to backport it to 4.18?
I'm asking because this PR was supposed to fix a 4.18 blocker, but it's currently on hold because if this revert.

@jpeimer
Copy link

jpeimer commented Dec 22, 2024 •
edited
Loading

Oh wait, I see now that the #4768 is a backport of a reverted PR.

@iholder101 iholder101 mentioned this pull request Dec 25, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@haircommander haircommander

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stbenjam @openshift-ci-robot @haircommander @rphillips @openshift-bot @jpeimer