OCPBUGS-17157: scripts: add a Go-based bumper, sync upstream #534
Conversation
stevekuznetsov
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Depends on #533 |
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
from
85d66d6 to
28ef8e7
Compare
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
from
28ef8e7 to
6860e99
Compare
|
/retest |
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
from
c3b46d2 to
8d87020
Compare
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
from
8d87020 to
d82ebff
Compare
This script sohuld be easier to maintain, automate, and have less historical baggage as compared to the shell scripts. As an example, the problem space of "cherry-pick some small number of commits on top of an in-sync branch" is much smaller than the "cherry-pick some unknownn number of commits on some dirty branch state with out-of-order commits already present." Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Plugins should re-use informers that the host started, since there's no need to double the number of watches and caches we're doing to reconcile the same set of objects in one process. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: a7f102afe51f8873d36499674ec674f62895585d Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
The abstraction here doesn't let you re-use an informer without also causing it to be re-registered and re-started, which is invalid. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 2be5e58b153eea608b6da16a8e3a1c46bc6c5b87 Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
from
d82ebff to
8ea9447
Compare
|
Rebased, should be ready |
|
/retest |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can't reproduce the unit failure locally... |
|
/retest |
|
/test all |
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
2 times, most recently
from
dd5db47 to
769b1e9
Compare
|
Missing one at least one upstream commit... but it's just OWNERS update, which doesn't really matter. |
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
from
769b1e9 to
cecdef1
Compare
We have code in this repository that is explicitly added as long-term carries in the staging directory. This commit allows labeling those carries and not failing on them. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Consume the informers that the host operator exposes in order to reduce resource consumption. A more straightforward approach would have been to share the shared informer factory itself, but that would have been more involved. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/sync-upstream
branch
from
67b26f7 to
f22a85b
Compare
| ## TODO | ||
| # Long-lived Carry Commits | ||
|
|
||
| * Add `make verify` to the `sync_pop_candidate.sh` and/or `sync.sh` scripts. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stevekuznetsov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
scripts: add a Go-based bumper
This script sohuld be easier to maintain, automate, and have less
historical baggage as compared to the shell scripts. As an example, the
problem space of "cherry-pick some small number of commits on top of an
in-sync branch" is much smaller than the "cherry-pick some unknownn
number of commits on some dirty branch state with out-of-order commits
already present."
Signed-off-by: Steve Kuznetsov skuznets@redhat.com