Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17157: go.mod: bump operator-framework/api #530

Closed
wants to merge 2 commits into from
Closed

OCPBUGS-17157: go.mod: bump operator-framework/api #530

wants to merge 2 commits into from

Conversation

stevekuznetsov
Copy link
Member

The clients in this controller deserialize the CatalogSource objects that are defaulted, so the version of the API in the client libraries of this controller determines what fields exist in the objects that get created, regardless of what the server knows about.

@stevekuznetsov
go.mod: bump operator-framework/api
86a5c8f 
The clients in this controller deserialize the CatalogSource objects
that are defaulted, so the version of the API in the client libraries of
this controller determines what fields exist in the objects that get
created, regardless of what the server knows about.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2023
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The clients in this controller deserialize the CatalogSource objects that are defaulted, so the version of the API in the client libraries of this controller determines what fields exist in the objects that get created, regardless of what the server knows about.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 8, 2023
@openshift-ci openshift-ci bot requested review from kevinrizza and theishshah August 8, 2023 13:44
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 8, 2023
Closed
38 tasks
@stevekuznetsov
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 8, 2023
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 8, 2023
@openshift-ci openshift-ci bot requested a review from jianzhangbjz August 8, 2023 13:47
@kevinrizza
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2023
@stevekuznetsov
Copy link
Member Author

/retest

@danilo-gemoli
Copy link

/test okd-scos-images

@stevekuznetsov
Copy link
Member Author

/retest

2 similar comments
@stevekuznetsov
Copy link
Member Author

/retest

@stevekuznetsov
Copy link
Member Author

/retest

@stevekuznetsov
Copy link
Member Author

/test all

@stevekuznetsov
Copy link
Member Author

/retest

@stevekuznetsov
Copy link
Member Author

Looks like the setting for community operators is too low, will fix later.

@stevekuznetsov
defaults: double memory targets
4262c94 
The first choice here seemed to be very optimistic.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

New changes are detected. LGTM label has been removed.

@jianzhangbjz
Copy link
Contributor

jianzhangbjz commented Aug 9, 2023 •
edited
Loading

It failed at   Error: open /proc/8505/stat: no such file or directory: container process not found and Failed to create pod sandbox: rpc error: code = Unknown desc = pod set memory limit 8388608 too low; should be at least 12582912, details in https://issues.redhat.com/browse/OCPBUGS-17157
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@danilo-gemoli
Copy link

/test okd-scos-images

This was referenced Aug 15, 2023
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 24, 2023
Merged
@stevekuznetsov
Copy link
Member Author

/retest

This was referenced Sep 5, 2023
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 18, 2023
Merged
@stevekuznetsov
Copy link
Member Author

/retest

@danilo-gemoli
Copy link

/uncc

@perdasilva
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp 4262c94 link false /test okd-scos-e2e-gcp
ci/prow/okd-e2e-gcp 4262c94 link false /test okd-e2e-gcp
ci/prow/e2e-gcp-console-olm 4262c94 link true /test e2e-gcp-console-olm
ci/prow/okd-scos-e2e-aws 4262c94 link false /test okd-scos-e2e-aws
ci/prow/e2e-gcp 4262c94 link true /test e2e-gcp
ci/prow/e2e-aws-ovn-serial 4262c94 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Sep 26, 2023
Merged
Merged
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

The clients in this controller deserialize the CatalogSource objects that are defaulted, so the version of the API in the client libraries of this controller determines what fields exist in the objects that get created, regardless of what the server knows about.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@theishshah theishshah Awaiting requested review from theishshah

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stevekuznetsov @openshift-ci-robot @kevinrizza @danilo-gemoli @jianzhangbjz @perdasilva