Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd-storage-test: apply 1.19 diff #25308

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 23, 2020

With hyperkube built from openshift/kubernetes this test must work with current version and rebase version. For that we check the server version and apply the 1.19 diff:

git diff origin/release-1.18 origin/release-1.19 test/integration/etcd/data.go

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
@hexfusion
Copy link
Contributor

/test e2e-aws-fips

@sttts
Copy link
Contributor Author

sttts commented Jul 23, 2020

/retest

@sttts sttts force-pushed the sttts-rebase-etcd-storage-test branch from 517ccd0 to a7314c4 Compare July 23, 2020 12:19
@mfojtik
Copy link
Contributor

mfojtik commented Jul 23, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link
Contributor Author

sttts commented Jul 23, 2020

/override ci/prow/e2e-aws-fips

@openshift-ci-robot
Copy link

@sttts: Overrode contexts on behalf of sttts: ci/prow/e2e-aws-fips

In response to this:

/override ci/prow/e2e-aws-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Contributor

mfojtik commented Jul 23, 2020

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-cmd
/override ci/prow/e2e-gcp

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-serial, ci/prow/e2e-cmd, ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-cmd
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit ac3482e into openshift:master Jul 23, 2020
@mfojtik
Copy link
Contributor

mfojtik commented Jul 23, 2020

Merging with button as this is blocking 1.19 rebase and was tested manually using local cluster.

@sttts sttts mentioned this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants