Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the USER env for e2e jobs #2048

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Set the USER env for e2e jobs #2048

merged 1 commit into from
Nov 2, 2018

Conversation

flaper87
Copy link
Contributor

@flaper87 flaper87 commented Nov 1, 2018

Sadly, the gophercloud/utils lib uses user.CurrentUser to load get the
user home dir. This fails with a panic error when used in environments
where such functionality is not available.

Let's set the USER env var for now until I fix this issue in
gophercloud.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2018
@flaper87
Copy link
Contributor Author

flaper87 commented Nov 1, 2018

/cc @sallyom

@flaper87 flaper87 mentioned this pull request Nov 1, 2018
Merged
@wking
Copy link
Member

wking commented Nov 2, 2018 •
edited
Loading

More on this issue in a different context here and in #1185. Should you set HOME too?

@flaper87
Copy link
Contributor Author

flaper87 commented Nov 2, 2018

@wking Thanks! I added HOME although I don't think I need it for this specific fix.

@flaper87
Set the USER env for e2e jobs
98045d5 
Sadly, the gophercloud/utils lib uses user.CurrentUser to load get the
user home dir. This fails with a panic error when used in environments
where such functionality is not available.

Let's set the `USER` env var for now until I fix this issue in
gophercloud.
@flaper87
Copy link
Contributor Author

flaper87 commented Nov 2, 2018

@wking done! Thanks a bunch for the review 😃

wking
wking approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@openshift-merge-robot openshift-merge-robot merged commit d4b9609 into openshift:master Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

@flaper87: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml

In response to this:

Sadly, the gophercloud/utils lib uses user.CurrentUser to load get the
user home dir. This fails with a panic error when used in environments
where such functionality is not available.

Let's set the USER env var for now until I fix this issue in
gophercloud.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

@steveej steveej Awaiting requested review from steveej

@sallyom sallyom Awaiting requested review from sallyom

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaper87 @wking @openshift-ci-robot @openshift-merge-robot