Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooling addition and go version bump #18

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Tooling addition and go version bump #18

merged 2 commits into from
Aug 16, 2018

Conversation

jpeeler
Copy link

@jpeeler jpeeler commented Jul 27, 2018

Adds a merge script and makes builds use go 1.10.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2018
@jpeeler
Copy link
Author

jpeeler commented Jul 27, 2018

/hold
Merge script may need to --squash, still investigating.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2018
tooling: bump go version to 1.10
ccebad3 
Upstream is using 1.10, so switch downstream buildling too.
tooling: add downstream merge script
a8fe603 
The goal for this script is to enable easy importing of upstream code,
which has to be done on a regular basis. The script is intentionally
not placed in the hack/ directory to avoid any conflicts with origin
tooling rebases.
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2018
@jpeeler
Copy link
Author

jpeeler commented Jul 30, 2018

/hold cancel
Merge script does not need to squash thankfully.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2018
@jpeeler
Copy link
Author

jpeeler commented Jul 30, 2018

/joke

@openshift-ci-robot
Copy link

@jpeeler: Why did the barber win the race? He took a short cut.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboyd01
Copy link

jboyd01 commented Aug 16, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jboyd01, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 884f498 into openshift:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jboyd01 jboyd01

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpeeler @openshift-ci-robot @jboyd01 @openshift-merge-robot