fix: variant annotation config #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0choa
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Thanks @RobinM-code for the bugfix!
We need to find a way to unit test the configs.
I updated the PR title to comply with conventional commits. Perhaps adding a template for PRs could help with this as well.
If you can bring the PR up-to-date with dev, we can merge it.
RobinM-code
force-pushed
the
rm/fix_variant_annotation_config
branch
from
ad91d58
to
52fc550
Compare
|
Hi @d0choa, Also, I think you mention some good suggestions that help in contributing to the code base. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.