-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pull request template #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have stylistic suggestions, based on the Transformers PR template
Currently our contribution guidelines are "polluted" with instructions about environment set up, we could improve this.
.github/pull_request_template.md
Outdated
@@ -0,0 +1,28 @@ | |||
## ✨ Context | |||
|
|||
<!--- What's the context for the changes? If the changes are related to a specific issue, please [link](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) to it:_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!--- What's the context for the changes? If the changes are related to a specific issue, please [link](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) to it:_ | |
<!--- | |
Congratulations! You've made it this far! | |
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your contribution. | |
What's the context for the changes? If the changes are related to a specific issue, please [link](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) to it:_ |
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Some nice work @d0choa, this will help for sure! Also:
Agree with this :) |
I think these are fine, if changes will be necessary later, it can always be updated. |
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty for the changes!
✨ Context
As discussed in @RobinM-code in #510, we would benefit from having a PR template so that contributors understand what are the expectations when opening new PRs.
🛠 What does this PR implement
A Github PR template.
🙈 Missing
Templates are a very subjective topic. I welcome any feedback you might have cc @RobinM-code @DSuveges @ireneisdoomed
🚦 Checks
dev
branchmake test
)poetry run pre-commit run --all-files
)