-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TL/MLX5: a2a part 1 -- coll init #790
Conversation
92af19e
to
f1881da
Compare
82e35e2
to
6d5e1c2
Compare
45064ab
to
bb36257
Compare
2d7e324
to
e00daac
Compare
Depends on #784 |
5445058
to
26ca009
Compare
26ca009
to
aebdc1f
Compare
aebdc1f
to
016a72a
Compare
@samnordmann please rebase |
@edgargabriel we are getting an error with Linter-ROCM
|
Hi @edgargabriel I am getting this error in PR #801 as well. |
I will have a look |
not entirely sure why that is happening, ucc compiles for me with rocm 5.6 without issues, probably a minor difference in the environment. I will try to remove an include path that is there for historic reasons but is not really required anymore, I think that is what is causing the issue. |
I think this is the cause of the issue, the version check fails for whatever reason and because of that it adds in the include path to the deprecated directories (which causes the issue). This test doesn't fail on my test systems
|
* TL/MLX5: a2a part 1 -- coll init * BUILD: fix inclusion path
* TL/MLX5: a2a part 1 -- coll init * BUILD: fix inclusion path
What
a2a part 1 -- coll init