Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC/CUDA: add mc managed and tests #801

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

shimmybalsam
Copy link
Collaborator

What

Adding support for memory type cudaManaged across UCC.

@shimmybalsam
Copy link
Collaborator Author

@edgargabriel please see small changes made in TL/ROCM

src/components/mc/cuda/mc_cuda.c Show resolved Hide resolved
src/components/mc/cuda/mc_cuda.c Show resolved Hide resolved
src/core/ucc_coll.c Show resolved Hide resolved
test/gtest/core/test_mc_reduce.cc Show resolved Hide resolved
@edgargabriel
Copy link
Contributor

@edgargabriel please see small changes made in TL/ROCM

@shimmybalsam thanks for the heads up. I tested your branch and things still work for ROCm with your change.

@shimmybalsam shimmybalsam force-pushed the mc_support_cuda_managed branch from 42248d6 to 084dafe Compare July 10, 2023 08:41
@shimmybalsam shimmybalsam requested a review from samnordmann July 10, 2023 08:41
src/components/mc/cuda/mc_cuda.c Show resolved Hide resolved
src/components/mc/cuda/mc_cuda.c Outdated Show resolved Hide resolved
@shimmybalsam shimmybalsam force-pushed the mc_support_cuda_managed branch from 084dafe to aa27757 Compare August 13, 2023 09:32
@Sergei-Lebedev Sergei-Lebedev force-pushed the mc_support_cuda_managed branch from aa27757 to ccad74e Compare August 21, 2023 06:37
@Sergei-Lebedev Sergei-Lebedev enabled auto-merge (squash) August 21, 2023 06:37
@Sergei-Lebedev Sergei-Lebedev merged commit b270265 into openucx:master Aug 21, 2023
samnordmann pushed a commit to samnordmann/ucc that referenced this pull request Aug 21, 2023
* MC/CUDA: support cudaManaged and tests

* REVIEW: minor fixes
@shimmybalsam shimmybalsam deleted the mc_support_cuda_managed branch August 29, 2023 06:58
nsarka pushed a commit to nsarka/ucc that referenced this pull request Oct 24, 2023
* MC/CUDA: support cudaManaged and tests

* REVIEW: minor fixes
nsarka pushed a commit to nsarka/ucc that referenced this pull request Oct 24, 2023
* MC/CUDA: support cudaManaged and tests

* REVIEW: minor fixes
janjust pushed a commit to janjust/ucc that referenced this pull request Jan 31, 2024
* MC/CUDA: support cudaManaged and tests

* REVIEW: minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants