【Hackathon 5th No.96】add paddle unstack op #20080
Conversation
Patrick-Star125
changed the title
Patrick-Star125
changed the title
| auto data = node.get_input("X"); | ||
| auto dim = node.get_attribute<int32_t>("axis"); | ||
| if (dim < 0) { | ||
| dim = dim + data.get_partial_shape().rank().get_length(); |
There was a problem hiding this comment.
Can we remove this line, because split op can accept negative axis: https://github.com/openvinotoolkit/openvino/blob/master/docs/articles_en/documentation/openvino_ir/operation_sets/operations_specifications/movement/Split_1.md
There was a problem hiding this comment.
have you validated it again? Could you help to update your uni-test screenshot if not ?
There was a problem hiding this comment.
sorry, missed the notification email, we should keep these code because index access of shape is bounded within [0, abs(dim)-1]
|
@yuxu42 Could you help to have a review on this PR, thanks |
|
@liubo-intel Could you please help review? Thanks! |
|
Done |
yuxu42
added
ExternalPR
|
Hi, @Patrick-Star125 : please fix the clang-format issue by following suggestion of the CI log. |
|
@ceciliapeng2011 can we merge the PR? Thanks! |
* add paddle mapping * develop test sampes * remove redundant code * revoke code change * add type mapping * add test sample * format code --------- Co-authored-by: Your Name <you@example.com>
Details:
add unstack operation in Paddle front end
Reference:
Requirements
unit-test