Update dependencies #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewwhitehead
commented
Jan 26, 2023
andrewwhitehead
commented
- Updates Rust crate dependencies
- Updates to Rust 2021 edition
- Fixes clippy warnings
| codegen-units = 1 | ||
| lto = true | ||
| panic = "abort" |
There was a problem hiding this comment.
What's the reason behind abort?
There was a problem hiding this comment.
It removes the panic unwinding, because a panic can't cross the FFI boundary and it potentially leaves things in an invalid state. This makes the binary smaller as well.
andrewwhitehead
force-pushed
the
upd/deps
branch
from
618a44e to
0508b3f
Compare
andrewwhitehead
force-pushed
the
upd/deps
branch
from
0508b3f to
e192a2c
Compare
TimoGlastra
previously approved these changes
Feb 3, 2023
|
I was planning to merge this for 0.2.8, but since it changes the Rust requirements (edition and version) it should likely be held off until 0.3. |
berendsliedrecht
previously approved these changes
Feb 15, 2023
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
dismissed stale reviews from berendsliedrecht and TimoGlastra
via
dfaa389
andrewwhitehead
force-pushed
the
upd/deps
branch
from
e192a2c to
dfaa389
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
upd/deps
branch
from
dfaa389 to
ec2b2af
Compare
|
Updating this PR because, based on the number of related projects creating breakages in the current build pipeline (including |
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
TimoGlastra
approved these changes
Mar 7, 2023
jamshale
pushed a commit
to jamshale/askar
that referenced
this pull request
Aug 18, 2024
…deps Update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.