Refactor storage into a separate crate #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
force-pushed
the
upd/refactor-storage
branch
from
fe9e766 to
ab9e837
Compare
andrewwhitehead
force-pushed
the
upd/refactor-storage
branch
from
03b0d83 to
3637a95
Compare
andrewwhitehead
force-pushed
the
upd/refactor-storage
branch
from
3637a95 to
b649038
Compare
berendsliedrecht
previously approved these changes
Apr 4, 2023
| @@ -126,7 +136,9 @@ fn percent_encode_into(result: &mut String, s: &str) { | |||
| push_iter_str(result, utf8_percent_encode(s, NON_ALPHANUMERIC)) | |||
| } | |||
|
|
|||
| /// A trait implemented by types that can be converted into Options | |||
| pub trait IntoOptions<'a> { | |||
There was a problem hiding this comment.
Is there a reason why TryInto for Options is not used? If this for some lower Rust version compatibility?
There was a problem hiding this comment.
It's actually because that creates issues accepting a straight Options instance - it implements From<Self> which means TryFrom<Self> is implemented with the Infallable error type, not the crate's error type.
Most of the changes there are added docstrings, but the |
andrewwhitehead
force-pushed
the
upd/refactor-storage
branch
from
b649038 to
c818ff2
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…emove_all Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
upd/refactor-storage
branch
from
5e4d07f to
8fa2043
Compare
jamshale
pushed a commit
to jamshale/askar
that referenced
this pull request
Aug 18, 2024
…refactor-storage Refactor storage into a separate crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves the public API of 'Store' and tidies up the crate exports.
Includes updates to scan records without a category filter (preparation for profile export/migration support).
In draft due to breaking changes, awaiting another minor release.
Follow up from #89