keepalived: remove file sync handling for ucitrack #23879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
The ucitrack file hanlding was converted to json. Therefore this is not needed anymore. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
feckert
force-pushed
the
pr/20240411-ucitrack
branch
from
e2b97b7
to
7889c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: no
Run tested: no
Description:
This depends on pullrequest in the
LuCIfeed.The
ucitrackconfiguration under/etc/configdefines which service must be restarted on aLuCIchange. Thisucifile defines how all this works together. Additionally there areuci-defaultsscripts in the various applications that add additional configurations parameters to thisucitrackfile if a service must be reloaded/restarted if aucichange was made in this application.There are some problems with the current implementation:
ucishould be used to configure the system and not for this kind of reload/restart dependency handling onLuCIchanges.ucifileucitrackthe new behavior onLuCIreload/restart could not take into account because the new file is not be used.